Skip to content

Conversation

@Thodd
Copy link
Collaborator

@Thodd Thodd commented Nov 13, 2024

When the enabled (resp. disabled) property exists, we need to also apply the sap/ui/core/EnabledPropagator mixin to the control wrapper.
This way the enabled state is propagated along the control tree.

@Thodd Thodd requested a review from petermuessig November 13, 2024 15:09
petermuessig
petermuessig previously approved these changes Nov 13, 2024
Copy link
Member

@petermuessig petermuessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermuessig
Copy link
Member

Unfortunately, you need to update the tests with: pnpm --filter ui5-tooling-modules test:snapshots

@petermuessig
Copy link
Member

About the wdi5 issue - hmm, don't know yet - maybe a one time issue...

@petermuessig petermuessig merged commit 774a209 into main Nov 14, 2024
4 of 5 checks passed
@petermuessig petermuessig deleted the seamless_webc_enabledpropagator branch November 14, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants