feat(ui5-tooling-modules): support HTMLElement as base class for webcomponents #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thodd
force-pushed
the
feat/html-element-wrapper-classes
branch
from
601145d to
ff53060
Compare
…omponents The rollup plugin for webcomponents now properly handles sap/ui/core/html/HTMLElement as a base class. This allows webcomponents to extend from it and be properly integrated into the UI5 rendering. The WebComponentRegistry is now able to resolve the superclass for webcomponents in the @ui5/html namespace to sap.ui.core.html.HTMLElement. Helper functions isUi5CoreHTMLElement and isHTMLElementBase have been added to WebComponentRegistryHelper.js to facilitate this change.
This commit introduces support for web components from the @ui5/html package (not final). The @ui5/html package provides the custom-elements.json to generate the HTMLElement wrapper classes. The changes include: - Refactoring the WebComponentRegistryHelper to provide a more generic isSubclassOf check. - Updating the rollup-plugin-webcomponents.js to handle the @ui5/html namespace. - Modifying the UI5Package.hbs template to conditionally include the webcPackage. - Adding @ui5/html as a dependency to the ui5-tsapp-webc showcase and updating the views to use the new components.
The d.ts generation for UI5 web components has been improved to support also non-UI5 web components (extending from HTMLElement). The metadata class is now dynamically determined based on the component's inheritance (e.g., HTMLElement or UI5Element) and imported accordingly.
Thodd
force-pushed
the
feat/html-element-wrapper-classes
branch
from
2852a9d to
8d53041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rollup plugin for webcomponents now properly handles sap/ui/core/html/HTMLElement as a base class. This allows webcomponents to extend from it and be properly integrated into the UI5 rendering.
The WebComponentRegistry is now able to resolve the superclass for webcomponents in the @ui5/html namespace to sap.ui.core.html.HTMLElement.
Helper functions isUi5CoreHTMLElement and isHTMLElementBase have been added to WebComponentRegistryHelper.js to facilitate this change.