fix(ui5-tooling-modules): references to webc-base/UI5Element now point to core.WebComponent #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to core WebComponent
Thodd
force-pushed
the
chore/modules/cleanup-serializer-coding
branch
from
19103b3 to
31fd428
Compare
Thodd
commented
Aug 15, 2025
| type = typeInfo?.references?.[0]?.name || type; | ||
|
|
||
| if (type === "ValueState" && typeInfo.references?.[0].package === "@ui5/webcomponents-base") { | ||
| if (typeInfo.references?.[0].package === "@ui5/webcomponents-base") { |
Collaborator
Author
There was a problem hiding this comment.
@H4ze: This solves the issue of misinterpreting the UI5Element.
There is only one relevant change in the test fixture: ShellBar.json now has the correct type for the content aggregation
Thodd
requested review from
H4ze and
petermuessig
and removed request for
petermuessig
Thodd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.