chore(ui5-tooling-modules): add typescript parser config and fix tooltip property handling #1256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
H4ze
commented
Aug 19, 2025
H4ze
commented
- Configure Prettier to use TypeScript parser for .ts/.tsx files
- Skip tooltip property in WebComponentRegistry to avoid conflicts with sap/ui/core/Element
- Fix some type issues in ui5-tsapp-webc
- Configure Prettier to use TypeScript parser for .ts/.tsx files - Skip tooltip property in WebComponentRegistry to avoid conflicts with sap/ui/core/Element - Fix some type issues in ui5-tsapp-webc
Remove tooltip property mapping from multiple webcomponent classes and update corresponding test snapshots.
Member
|
@H4ze : should this be reviewed and released? To me it looks good and IMO, you can also declare this as a fix! |
Collaborator
Author
|
@petermuessig Yes, sorry I somehow forgot, that this PR is still open :/ |
petermuessig
approved these changes
Sep 5, 2025
petermuessig
deleted the
chore/modules/fix-generated-ts-def-and-cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.