Skip to content

fix(ui5-tooling-modules): change defaults for prettier #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petermuessig merged 2 commits into from
Sep 30, 2025
Merged

fix(ui5-tooling-modules): change defaults for prettier #1276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16330bc
fix(ui5-tooling-modules): change defaults for prettier
petermuessig Sep 30, 2025
16951b4
chore(ui5-tooling-modules): fix tests
petermuessig Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions packages/ui5-tooling-modules/lib/rollup-plugin-webcomponents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,13 @@ module.exports = function ({ log, resolveModule, pkgJson, getPackageJson, framew
type: "prebuilt-chunk",
id: source,
fileName: `${source}.js`,
code: prettier.format(code, { semi: false, parser: "babel" }),
code: prettier.format(code, {
// TODO: read from prettier config if existing
// otherwise use some defaults
semi: true,
trailingComma: "none",
parser: "babel",
}),
});

// store the metadata
Expand Down Expand Up @@ -341,7 +347,13 @@ module.exports = function ({ log, resolveModule, pkgJson, getPackageJson, framew
type: "prebuilt-chunk",
id: resolvedSource,
fileName: `${resolvedSource}.js`,
code: prettier.format(code, { semi: false, parser: "babel" }),
code: prettier.format(code, {
// TODO: read from prettier config if existing
// otherwise use some defaults
semi: true,
trailingComma: "none",
parser: "babel",
}),
});

// store the metadata
Expand Down
16 changes: 14 additions & 2 deletions packages/ui5-tooling-modules/lib/utils/DTSSerializer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,13 @@ const DTSSerializer = {
Templates.module({
registryEntry,
}),
{ semi: false, parser: "typescript" },
{
// TODO: read from prettier config if existing
// otherwise use some defaults
semi: true,
trailingComma: "none",
parser: "typescript",
},
)
.then((prettifiedTypes) => {
if (prettifiedTypes) {
Expand All @@ -334,7 +340,13 @@ const DTSSerializer = {
clazz: registryEntry.classes[clazz],
BINDING_STRING_PLACEHOLDER: "`{${string}}`",
}),
{ semi: false, parser: "typescript" },
{
// TODO: read from prettier config if existing
// otherwise use some defaults
semi: true,
trailingComma: "none",
parser: "typescript",
},
)
.then((prettifiedTypes) => {
if (prettifiedTypes) {
Expand Down
Loading
Loading