Skip to content
This repository was archived by the owner on Nov 8, 2024. It is now read-only.

add pressTile step#1

Open
vl-leon wants to merge 3 commits into
mainfrom
add-press-tile-step
Open

add pressTile step#1
vl-leon wants to merge 3 commits into
mainfrom
add-press-tile-step

Conversation

@vl-leon

@vl-leon vl-leon commented Jun 28, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@vl-leon vl-leon requested a review from vobu June 28, 2024 16:32
Comment thread lib/index.js Outdated
@@ -0,0 +1,6 @@
let { Given, When, Then } = require('@cucumber/cucumber');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

essentially the same const vs let remark that I already left in the wdi5-fe-selectors repo

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread lib/index.js Outdated
let { Given, When, Then } = require('@cucumber/cucumber');
let lib = require('wdi5-fe-selectors');

Given('we press tile {string}', async function (name) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any need for the this-scoped function as opposed to async (name) => {?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done - no reason currently

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants