perf(ci): remove duplicate skill verification - #70
Merged
Conversation
![slopzapper[bot]](https://avatars.githubusercontent.com/in/4527847?s=60&v=4){kind=small}
There was a problem hiding this comment.
✨ CLEAN
Deleting skills-lint.yml is safe: verify.yml already runs pnpm run verify, which includes skillcheck lint, on every pull request. The pnpm-before-setup-node reorder and frozen-lockfile install match the documented cache contract and keep the PR plus monthly gate intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pull requests install the same dependencies twice and run
skills:linttwice. The authoritative workflows also disabled the pnpm store cache, so every run paid the cold dependency-download cost.Solution
Keep
pnpm run verifyas the single pull-request and monthly gate. Cache the pnpm store in both workflows, use a visible frozen install step, and absorb the pending pnpm action update.Proof
PR #69 spent 41 seconds in Verify plus 36 seconds in the duplicate Skills lint workflow. PR #70 has one Verify job: 51 seconds cold, then 35 seconds with the 700 MB pnpm store restored; all four independent scan jobs pass in 8–15 seconds. The local repository gate passes in 5.26 seconds.