feat(search): add local result filters#4
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds exact, local-only result filters to fincrawl search (state / Fin status / tag) and exposes them consistently across the CLI schema, docs, and synthetic tests.
Changes:
- Introduces
store.SearchWithOptions/SearchOptionsand applies optional exact filters in both the FTS and LIKE search paths. - Adds
--state,--fin-status, and--tagflags tofincrawl search, and updatesdescribe searchschema output. - Updates agent-facing docs/examples and expands synthetic tests to cover the new filters.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| skills/fincrawl/SKILL.md | Adds CLI examples demonstrating --state and --fin-status filtering. |
| skills/fincrawl/references/reads.md | Documents and exemplifies the new exact filters for agent/operator usage. |
| README.md | Updates common-flow examples to include filtered search usage. |
| internal/store/search.go | Implements filterable search via SearchOptions and shared SQL filter construction for FTS/LIKE. |
| internal/store/fixture_test.go | Adds store-level tests validating filtered searches against the synthetic fixture DB. |
| internal/cli/cli.go | Wires new search flags into CLI parsing and store search invocation. |
| internal/cli/cli_test.go | Adds CLI-level test coverage for filtered search behavior and schema output. |
| internal/cli/agent_dx.go | Extends machine-readable describe search schema to include new flags and examples. |
| docs/roadmap.md | Notes the addition of search filters as a delivered capability. |
| docs/architecture.md | Updates architecture command examples to include filter flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state,fin-status, andtagfilters to local archive searchfincrawl describe searchand CLI flagsVerification
FINCRAWL_SOURCE=/Users/altay/projects/uinaf/fincrawlusing redacted aggregate outputData Boundary
Complexity
Summary by cubic
Add exact result filters to local archive search to narrow results by state, Fin status, and tag. Exposes new CLI flags and updates docs and tests.
Written for commit bf79799. Summary will update on new commits. Review in cubic