Skip to content

feat(search): add local result filters#4

Merged
altaywtf merged 1 commit into
mainfrom
feat/search-filters
May 17, 2026
Merged

feat(search): add local result filters#4
altaywtf merged 1 commit into
mainfrom
feat/search-filters

Conversation

@altaywtf

@altaywtf altaywtf commented May 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Add exact state, fin-status, and tag filters to local archive search
  • Expose the new filters through fincrawl describe search and CLI flags
  • Update agent-facing search docs and synthetic tests

Verification

  • ./scripts/verify
  • ./scripts/release-check
  • go run ./cmd/fincrawl describe search --json
  • Markdown local link check
  • Private-store smoke with FINCRAWL_SOURCE=/Users/altay/projects/uinaf/fincrawl using redacted aggregate output

Data Boundary

  • Synthetic tests only; no tenant credentials, identifiers, transcript data, generated snapshots, logs, reports, screenshots, or transcript-derived examples added.

Complexity

  • Neutral: search keeps the existing FTS/LIKE paths and adds parameterized exact filters.

Summary by cubic

Add exact result filters to local archive search to narrow results by state, Fin status, and tag. Exposes new CLI flags and updates docs and tests.

  • New Features
    • Added search flags: --state, --fin-status, and --tag.
    • Updated describe schema and examples to show the new flags.
    • Implemented SearchOptions and SearchWithOptions; filters applied to both FTS and LIKE paths.
    • Added synthetic tests for filtered queries and CLI projection.
    • Updated README, architecture docs, skills references, and roadmap with examples.

Written for commit bf79799. Summary will update on new commits. Review in cubic

Copilot AI review requested due to automatic review settings May 17, 2026 16:29

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Re-trigger cubic

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds exact, local-only result filters to fincrawl search (state / Fin status / tag) and exposes them consistently across the CLI schema, docs, and synthetic tests.

Changes:

  • Introduces store.SearchWithOptions / SearchOptions and applies optional exact filters in both the FTS and LIKE search paths.
  • Adds --state, --fin-status, and --tag flags to fincrawl search, and updates describe search schema output.
  • Updates agent-facing docs/examples and expands synthetic tests to cover the new filters.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
skills/fincrawl/SKILL.md Adds CLI examples demonstrating --state and --fin-status filtering.
skills/fincrawl/references/reads.md Documents and exemplifies the new exact filters for agent/operator usage.
README.md Updates common-flow examples to include filtered search usage.
internal/store/search.go Implements filterable search via SearchOptions and shared SQL filter construction for FTS/LIKE.
internal/store/fixture_test.go Adds store-level tests validating filtered searches against the synthetic fixture DB.
internal/cli/cli.go Wires new search flags into CLI parsing and store search invocation.
internal/cli/cli_test.go Adds CLI-level test coverage for filtered search behavior and schema output.
internal/cli/agent_dx.go Extends machine-readable describe search schema to include new flags and examples.
docs/roadmap.md Notes the addition of search filters as a delivered capability.
docs/architecture.md Updates architecture command examples to include filter flags.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@altaywtf
altaywtf merged commit cbdb576 into main May 17, 2026
7 checks passed
@altaywtf
altaywtf deleted the feat/search-filters branch May 17, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants