feat(timeout): redirect to form start page and support new config fields#384
Merged
emilyjevans merged 2 commits intoMay 28, 2025
Merged
Conversation
- Fix timeout.html redirecting incorrectly to the /config route by using the injected referer instead. (See: https://github.com/ukhsa-collaboration/digital-form-builder/blob/801bc7de3d8f57d316bc46a67518ef07914f54c3/runner/src/server/plugins/router.ts#L263)) - Timeout now correctly redirects to the form's start page. - Add support for new serviceName form field. This may overlap with existing name field... May be removed based on feedback. Use new fullStartPage form field instead of the global serviceStartPage setting. (Overrides config at https://github.com/ukhsa-collaboration/digital-form-builder/blob/801bc7de3d8f57d316bc46a67518ef07914f54c3/runner/config/default.js#L59 )
emilyjevans
reviewed
May 28, 2025
emilyjevans
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix timeout.html redirecting incorrectly to the /config route by using the injected referer instead.
(See:
digital-form-builder/runner/src/server/plugins/router.ts
Lines 256 to 265 in 801bc7d
Timeout now correctly redirects to the form's start page.
Add support for new serviceName form field. This may overlap with existing name field... May be removed based on feedback.
Use new fullStartPage form field instead of the global serviceStartPage setting. (Overrides config at
digital-form-builder/runner/config/default.js
Line 59 in 801bc7d
Example usage:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested locally.
Checklist: