refactored Regex to be cleaner#618
Merged
Merged
Conversation
NovaGlow
commented
Jun 10, 2026
NovaGlow
left a comment
NovaGlow
left a comment
Author
There was a problem hiding this comment.
I have refactored the Regex to allow for 10 to 12 digits and allows various styles of phone number to be added as long as they are valid numbers
Dashue
approved these changes
Jun 10, 2026
LatinRickshaw
approved these changes
Jun 10, 2026
|
I'm happy with the changes from a test perspective. Test evidence is here: https://ukhsa.atlassian.net/wiki/spaces/L2L3S/pages/555450564/RITM0230227+-RAO+Telephone+formatting |
melissafisher-ukhsa
approved these changes
Jun 10, 2026
Chukwunonso
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated and refactored the Regex to be cleaner and better validation, manual testing seems to work.