Skip to content

Improve matching stova attendees to existing companies #6011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DeanElliott96
Copy link
Contributor

@DeanElliott96 DeanElliott96 commented Mar 20, 2025

Description of change

Previously there was only a check to match on the given company_name from stova. Now it checks company_name first, and if no match it checks the attendees email for a contact match and uses that contacts company.

Currently: 19.65% attendees matched to existing companies

Of all 87310 Stova attendees ingested
17160 attendees were matched to existing companies
70150 attendees were assigned a newly created company from Stova
This created 35751 new companies on Data Hub

With this PR: 54% attendees matched to existing companies

Of all 87310 Stova attendees
47840 attendees would be matched to existing companies
39470 remaining attendees will be assigned a newly created company by Stova
This would create 26228 new companies on Data Hub

Checklist

  • Has this branch been rebased on top of the current main branch?
  • Is the CircleCI build passing?

Previously there was only a check to match on the given company_name from
stova. Now it checks company_name first, and if no match it checks the
attendees email for a contact match and uses that contacts email address.
@DeanElliott96 DeanElliott96 self-assigned this Mar 20, 2025
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (ccdcc91) to head (dbdeb64).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6011      +/-   ##
==========================================
- Coverage   96.67%   96.66%   -0.01%     
==========================================
  Files        1094     1094              
  Lines       25802    25816      +14     
  Branches     1699     1703       +4     
==========================================
+ Hits        24943    24956      +13     
- Misses        700      701       +1     
  Partials      159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant