LTD-6168-drop-customisation-text #2471
Merged
+56
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {% crispy form %} | ||
|
|
||
| <h1 class="govuk-heading-l">{% block title %}Generate document{% endblock %}</h1> | ||
| <p id="subtitle" class="govuk-body"><strong>This is a preview of the letter. Check the preview is correct and then hit “Generate”</strong></p> |
There was a problem hiding this comment.
You can use BaseForm for all this HTML so you would just need the form itself. Something like this:
class GenerateDocumentForm(BaseForm):
class Layout:
TITLE = "Generate document"
SUBTITLE = "This is a preview of the letter. Check the preview is correct and then hit “Generate”"
SUBMIT_BUTTON_TEXT = "Generate"'
def get_layout_fields(self):
return (HTML('<div class="app-letter-preview__page" id="preview">{{ preview|safe }}</div><br>'),)
There was a problem hiding this comment.
The form is being used for the buttons only
We inject the preview of the document in the middle and we need the title(s) and text at the top
and the buttons and actions of the form at the bottom.
There was a problem hiding this comment.
I've updated my comment to include info about the preview too as you can just inject that bit of HTML into the layout.
There was a problem hiding this comment.
def get_layout_fields(self):
return (HTML('{{ preview|safe }}
'),)
ok fair enough i've refactored the template to accommodate, agree it's much neater now.
depsiatwal
force-pushed
the
LTD-6168-drop-customisation-text
branch
from
44b4b42 to
58186c4
Compare
saruniitr
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the ability to customise and repeat preview of letter.
Now this allows review initially then the user needs to generate the letter