feature/node-identity #84
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Sources/UB/Node.swift
Outdated
| transports[id] = transport | ||
| transports[id]?.delegate = self | ||
| transport.listen() | ||
| transport.listen(identity: UBID(repeating: 0, count: 0)) // @TODO |
There was a problem hiding this comment.
TODOs should be resolved.
…-beam/UB.swift into feature/node-identity
…-beam/UB.swift into feature/node-identity
| type: CBUUID(string: "BEA3B031-76FB-4889-B3C7-000000000001"), | ||
| properties: [.read, .writeWithoutResponse, .notify], | ||
| value: nil, | ||
| permissions: [.writeable, .readable] |
There was a problem hiding this comment.
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.
| } | ||
|
|
||
| if request.characteristic.uuid == identityCharacteristic.uuid { | ||
| delegate?.transport(self, didConnectToPeer: Addr(data), withAddr: Addr(request.central.identifier.bytes)) |
There was a problem hiding this comment.
Line should be 120 characters or less: currently 121 characters
| if characteristic.uuid == identityCharacteristic.uuid { | ||
| if let data = characteristic.value { | ||
| let addr = Addr(data) | ||
| peers[id] = addr; |
There was a problem hiding this comment.
Lines should not have trailing semicolons.
| let sends = flood(message, data: data, transport: transport, peers: filtered) | ||
| if sends > 0 { | ||
| return | ||
| return filtered.forEach { |
There was a problem hiding this comment.
Avoid too many return statements within this function.
| ) { | ||
| add(central: central) | ||
| if characteristic.uuid == CoreBluetoothTransport.identityCharacteristic.uuid { | ||
| peripheral.updateValue(Data(identity), for: CoreBluetoothTransport.identityCharacteristic, onSubscribedCentrals: [central]) |
There was a problem hiding this comment.
Line should be 120 characters or less: currently 135 characters
|
Code Climate has analyzed commit e37e58f and detected 7 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.