Conversation
|
👋 Hello @glenn-jocher, thank you for your
For further information, consult our Contributing Guide. Feel free to add comments here if you have any questions or need further assistance. Thanks for enhancing Ultralytics with your contributions! 🚀✨ |
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
The new entrypoint never performs or enforces the CLA verification, so the action currently offers no protection. Please add the actual CLA validation logic before shipping this.
💬 Posted 1 inline comment
| print("RUNNING CHECK_CLA FUNCTION") | ||
| os.environ.get("GITHUB_TOKEN") | ||
| os.environ.get("CLA_REPOSITORY") | ||
| os.environ.get("CLA_BRANCH") | ||
| os.environ.get("CLA_SIGNATURES_PATH") | ||
| os.environ.get("CLA_DOCUMENT_URL") | ||
| os.environ.get("ALLOWLIST", "").split(",") | ||
| os.environ.get("SIGN_COMMENT") | ||
| os.environ.get("ALLSIGNED_COMMENT") | ||
|
|
||
| # Your CLA check logic here | ||
| # Note: You can extract the organization and repository name if needed: | ||
| # org, repo = cla_repository.split('/', 1) if '/' in cla_repository else ('', cla_repository) | ||
|
|
||
| # ... rest of your CLA check logic ... | ||
|
|
There was a problem hiding this comment.
❗ CRITICAL: main() exits successfully without consuming any of the inputs or performing a CLA check, so the action will never catch unsigned contributors. Please implement the verification logic (and fail fast when checks fail) before wiring this into workflows; otherwise every run will report success regardless of CLA status.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
This PR introduces a new GitHub action to ensure contributors have signed the Ultralytics Contributor License Agreement (CLA). 🚀
📊 Key Changes
action.ymlfile for the Ultralytics CLA GitHub Action.🎯 Purpose & Impact