-
Notifications
You must be signed in to change notification settings - Fork 7
Support for Easy Effects v8+ (QT port) #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This adds new method for getting last used presets and changes how to parse the output of -p (--presets) option on the new QT version. Getting the last used preset does not work reliably with the new method (at least for flatpak). Need to work together with EE team to find a reliable solution. Also getting the value of global bypass state is disabled until we implement a new solution. Setting it should work though.
|
Thanks for the update! Installs and runs fine on GNOME 49 with EasyEffects 8.0.4. But I see three major issues at the moment:
Issue one seems to be a side effect of the command line flags. Even just querying the available preset with The second one is likely caused by the active preset being queried from the config database, which has a default autosave interval of 30s (can be configured). We could mitigate this by caching the last change performed by the extension for some time, but this of doesn't guarantee this is really the active present. But ideally, EasyEffects shouldn't rely on the config database for this. Number three should probably be fixed on the extension's side, by first checking if EasyEffects is running before running any commands that would launch the EasyEffects service. |
|
And also the global bypass toggle doesn't work at the moment, but I see you already opened an issue about this upstream. |
|
Thanks for the feedback! I'm aware of most of the problems you've stated, thus it's still not merged. It's not ready for the prime time yet.
|
| if (appType === 'flatpak') { | ||
| // If Flatpak make sure to wait min 1sec before getting last presets | ||
| const waitTimeMs = easyEffectsIsQT ? 35000 : 1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The database autosave interval is 30s by default on all platforms, so not only Flatpak is affected. I still think this should be fixed upstream though; EasyEffects should actually report the active preset and not the one saved in the db.
This adds new method for getting last used presets and changes how to parse the output of -p (--presets) option on the new QT version. Getting the last used preset does not work reliably with the new method (at least for flatpak). Need to work together with EE team to find a reliable solution. Also getting the value of global bypass state is disabled until we implement a new solution. Setting it should work though.