Skip to content

Conversation

VAWVAW
Copy link
Contributor

@VAWVAW VAWVAW commented Sep 12, 2025

This adds :reload to reload some config options.

Options not currently affected:

  • log_level
  • image previews
  • ...

Further testing is needed to see which options need to be handled in code.

fixes #505

@fuguesoft
Copy link

I'll have a look at this

@fuguesoft
Copy link

fuguesoft commented Sep 13, 2025

@VAWVAW
When building with rust, where do I need to configure things?
It doesn't seem to be using the default location but I'm new to this so it's probably user error

ah nvm, just gotta get past the initial sign-on

@fuguesoft
Copy link

fuguesoft commented Sep 13, 2025

Okay yeah maybe I built this wrong.
There doesn't seem to be a reload command it can find.

I pulled your fork down and checked out the hot-reload branch.
Then I did:

cargo install --locked iamb

Found the correct compiling instructions
Yep still no :reload command

Followed these instructions from the docs (slightly modified):

$ gh repo clone VAWVAW/iamb.git hot-reload
$ cd hot-reload
$ git checkout -b hot-reload
$ cargo build --release
$ ./target/release/iamb --version
iamb 0.0.10 (2e6376f)

@VAWVAW
Copy link
Contributor Author

VAWVAW commented Sep 13, 2025

You still haven't got the right branch. The version should be iamb 0.0.11-alpha.1 (ee662d9).

git checkout -b creates a new branch`

I can run the branch using:

$ git clone -b hot-reload https://github.com/vawvaw/iamb
$ cd iamb
$ cargo build
$ ./target/debug/iamb --version
iamb 0.0.11-alpha.1 (ee662d9)

@fuguesoft
Copy link

I got it and from what I can see, the notifications don't seem to be resetting
keymaps seem to change on reload

Are there ways to send you logs or some sort of debug for this?

@VAWVAW
Copy link
Contributor Author

VAWVAW commented Sep 18, 2025

No, there are no relevant logs.

This PR currently only replaces the in-memory representation of the config. But there are a lot of other places in the code where the settings might be copied or applied.

I need a list of all config options that don't just work and need some extra code to handle.

Some of them might be too complex to implement.

@fuguesoft
Copy link

ah okay I'll make another profile and do some more testing

so far I don't see notification settings updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Hot Reload Config

2 participants