-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Feature: Batch‑delete websites (FR #3320) #3438 #3442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Correct example description for Umami version in bug report template
@The-Yearly is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR implements batch website deletion functionality, allowing users to select and delete multiple websites simultaneously through a checkbox interface and confirmation modal.
- Added checkbox column and delete icon in
src/app/(main)/settings/websites/WebsitesTable.tsx
for multi-select functionality - Implemented batch deletion logic in
src/app/(main)/settings/websites/[websiteId]/WebsiteDeleteForm.tsx
to handle array of website IDs - Added state management for selected websites using
deleteIds
and confirmation modal inWebsitesTable.tsx
- Integrated
useModified
hook inWebsitesDataTable.tsx
andUserWebsites.tsx
to refresh UI after batch deletions - Added safety confirmation with different
CONFIRM_VALUE
strings for single ('DELETE') vs batch ('DELETE MULTIPLE') operations
💡 (5/5) You can turn off certain types of comments like style here!
7 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
src/app/(main)/settings/websites/[websiteId]/WebsiteDeleteForm.tsx
Outdated
Show resolved
Hide resolved
@mikecao could u pls review this |
This PR adds the ability to select and delete multiple websites in one action refer #3320
Why
How it works
Screen Shots:
I have done the same for websites tab and websites tab under users in settings also