fix: URL hash is not included in record #3445
Conversation
|
@Nambers is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes URL hash tracking in Umami analytics by appending the hash component to the pathname when recording events, addressing issue #3444 where data-exclude-hash="false" was not working as expected.
- Modified
src/app/api/send/route.tsto includecurrentUrl.hashin theurlPathvariable for event tracking - Ensures proper handling of URLs with hash fragments like
test/albums/de25/#ea03593jpg
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -145,7 +145,7 @@ export async function POST(request: Request) { | |||
| const base = hostname ? `https://${hostname}` : 'https://localhost'; | |||
| const currentUrl = new URL(url, base); | |||
|
|
|||
| let urlPath = currentUrl.pathname === '/undefined' ? '' : currentUrl.pathname; | |||
| let urlPath = currentUrl.pathname === '/undefined' ? '' : currentUrl.pathname + currentUrl.hash; | |||
There was a problem hiding this comment.
style: Consider handling empty hash values to avoid appending '#' with no value
There was a problem hiding this comment.
hmm I don't think this is an issue here? it's not hurt to add empty trailing string
fix #3444