Support pnpm 11#4279
Conversation
|
@Maxime-J is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryThis PR updates the pnpm workspace configuration and Dockerfile to be compatible with pnpm 11, which changed the default build-script policy to strict mode and deprecated
Confidence Score: 4/5The Docker build changes are self-contained and follow the documented pnpm 11 migration path; the main open question is whether @prisma/client 7.x has an active postinstall that needs to be listed in allowBuilds. The Dockerfile changes are well-structured and the strictDepBuilds: false / verifyDepsBeforeRun: false workarounds are sound. The one outstanding question — whether @prisma/client 7.x ships lifecycle scripts that require an entry in allowBuilds — could silently block local developer installs if it turns out the package still has a postinstall. Everything else in the migration looks correct and consistent with pnpm 11 documentation. pnpm-workspace.yaml — verify that @prisma/client does not require an allowBuilds entry with Prisma 7 Important Files Changed
Reviews (1): Last reviewed commit: "Support pnpm 11" | Re-trigger Greptile |
|
See resolved conversations above for Greptile's question on its confidence score. |
pnpm 11 being tagged as latest version, this introduced errors on install and broken Docker build.
In this PR:
-Migration to the
allowBuildssetting, following the default strict policy (all packages needs to be reviewed, error otherwise)(I followed the previous behavior, but you might want to allow other packages.)
- In Dockerfile
depsstage, disable the strict policy so that nothing is built (like before), without error.- In Dockerfile
runnerstage:verifyDepsBeforeRun: falseis now needed to prevent pnpm from running install on pnpm run.--allow-buildflag onpnpm addreplaced withallowBuildson that new workspace file.