Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the non-controversial, straightforward obsoleted constructs for Umbraco 16 #18661

Open
wants to merge 82 commits into
base: v16/dev
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
c5667e4
Removed obsoletes from IConfigManipulator.
AndyButland Mar 12, 2025
bf54ff1
Removed obsolete models builder extensions.
AndyButland Mar 12, 2025
a7188d0
Removed the obsolete ContentDashboardSettings.
AndyButland Mar 12, 2025
e1ae059
Removed the obsolete InstallMissingDatabase setting on GlobalSettings.
AndyButland Mar 12, 2025
ab3805b
Removed obsolete NuCache settings.
AndyButland Mar 12, 2025
b111590
Removed obsolete RuntimeMinificationSettings.
AndyButland Mar 12, 2025
a51720b
Removed obsolete health check constant.
AndyButland Mar 12, 2025
fe9fc0a
Removed obsolete icon constant.
AndyButland Mar 12, 2025
66761a5
Removed obsolete telemetry constant.
AndyButland Mar 12, 2025
1ab8150
Removed obsolete property and constructor on UmbracoBuilder.
AndyButland Mar 12, 2025
9e64fd9
Removed obsolete constructor on AuditNotificationsHandler.
AndyButland Mar 12, 2025
b5a0d60
Removed obsolete constructor on HTTP header health checks.
AndyButland Mar 12, 2025
cdb124e
Removed obsolete constructor on MediaFileManager.
AndyButland Mar 12, 2025
03f4a60
Removed obsolete GetDefaultFileContent on ViewHelper.
AndyButland Mar 12, 2025
a238880
Remove obsoleted methods on embed providers.
AndyButland Mar 12, 2025
823ed88
Fix tests.
AndyButland Mar 12, 2025
1913dd4
Removed obsolete constructors on BlockEditorDataConverter.
AndyButland Mar 12, 2025
1e24bbc
Removed obsolete SeedCacheDuration property on CacheSettings.
AndyButland Mar 12, 2025
1f3e881
Removed obsolete PublishCulture on ContentRepositoryExtensions.
AndyButland Mar 12, 2025
12b3cd5
Removed obsolete MonitorLock.
AndyButland Mar 12, 2025
3c43db2
Removed obsolete synchronous HasSavedValues from IDataTypeUsageServic…
AndyButland Mar 12, 2025
2ab9b3b
Removed obsolete HasSavedPropertyValues from IPropertyTypeUsageServic…
AndyButland Mar 12, 2025
db894d0
Removed obsolete methods in ITrackedReferencesService and ITrackedRef…
AndyButland Mar 12, 2025
9e64c74
Removed obsolete DateValueEditor constructors.
AndyButland Mar 12, 2025
e48b8bc
Removed obsolete GetAutomaticRelationTypesAliases.
AndyButland Mar 12, 2025
40f67d8
Removed obsolete constructor on TextOnlyValueEditor.
AndyButland Mar 12, 2025
3526625
Removed obsolete constructors on RegexValidator and RequiredValidator.
AndyButland Mar 12, 2025
b91546a
Removed obsolete constructs on SliderValueConverter and TagsValueConv…
AndyButland Mar 12, 2025
d4a93da
Removed obsolete GetContentType methods from IPublishedCache.
AndyButland Mar 12, 2025
c3dbca5
Removed ContentFinderByIdPath.
AndyButland Mar 12, 2025
4fbb73f
Removed obsolete constructor on DefaultMediaUrlProvider.
AndyButland Mar 12, 2025
2d3a994
Removed obsolete constructor on Domain.
AndyButland Mar 12, 2025
8a4ce56
Removed obsolete constructor on PublishedRequest.
AndyButland Mar 12, 2025
9fa4822
Removed obsolete methods on CheckPermissions.
AndyButland Mar 12, 2025
928ecbb
Removed obsolete GetUserId from IBackOfficeSecurity.
AndyButland Mar 12, 2025
62c8423
Removed obsolete methods on LegacyPasswordSecurity.
AndyButland Mar 12, 2025
891cbde
Removed obsolete constructors on AuditService.
AndyButland Mar 12, 2025
9181e66
Removed obsolete methods on IContentEditingService.
AndyButland Mar 12, 2025
a4dbe62
Remove obsolete constructors and methods on ContentService/IContentSe…
AndyButland Mar 12, 2025
df69bd9
Removed obsolete constructor in ContentTypeEditingService.
AndyButland Mar 12, 2025
373f848
Removed obsolete constructor in MediaTypeEditingService.
AndyButland Mar 12, 2025
aff8ccb
Removed obsolete constructor in MemberTypeEditingService.
AndyButland Mar 12, 2025
d3e7ceb
Removed obsolete constructor in ContentTypeService.
AndyButland Mar 12, 2025
4c15d0e
Removed obsolete constructors in ContentTypeServiceBase.
AndyButland Mar 12, 2025
61df5db
Removed obsolete constructors and methods in ContentVersionService.
AndyButland Mar 12, 2025
e387702
Removed obsolete constructor in DataTypeUsageService.
AndyButland Mar 12, 2025
76cfdd4
Removed obsolete constructor in DomainService.
AndyButland Mar 12, 2025
5a9eb4e
Removed obsolete constructor in FileService.
AndyButland Mar 12, 2025
99b04a9
Removes obsolete AttemptMove from IContentService.
AndyButland Mar 12, 2025
2b2a802
Removes obsolete SetPreventCleanup from IContentVersionService.
AndyButland Mar 12, 2025
566f4bb
Removes obsolete GetReferences from IDataTypeService.
AndyButland Mar 12, 2025
bfc79c5
Removed obsolete SetConsentLevel from IMetricsConsentService.
AndyButland Mar 12, 2025
7e363e0
Removed obsolete methods from IPackageDataInstallation.
AndyButland Mar 12, 2025
cd54c2e
Removed obsolete methods from IPackagingService.
AndyButland Mar 12, 2025
5320f52
Removed obsolete methods on ITwoFactorLoginService.
AndyButland Mar 12, 2025
df1aed7
Removed obsolete constructor from MediaService, MemberTypeService and…
AndyButland Mar 12, 2025
cb0585b
More obsolete constructors.
AndyButland Mar 12, 2025
6207043
Removed obsoleted overloads on IPropertyValidationService.
AndyButland Mar 12, 2025
2d64d9d
Fixed build for tests.
AndyButland Mar 12, 2025
d266228
Removed obsolete constructor for PublicAccessService, UserService and…
AndyButland Mar 12, 2025
a92398f
Removed GetDefaultMemberType.
AndyButland Mar 12, 2025
d871be1
Removed obsolete user group functionality from IUserService.
AndyButland Mar 12, 2025
a992836
Removed obsolete extension methods on IUserService.
AndyButland Mar 12, 2025
c581c52
Removed obsolete method from ITelemetryService.
AndyButland Mar 12, 2025
d67bf38
Removed obsolete UdiParserServiceConnectors.
AndyButland Mar 12, 2025
e403ebe
Removed obsolete method on ICookieManager.
AndyButland Mar 12, 2025
cb16045
Removed obsolete DynamicContext.
AndyButland Mar 12, 2025
4e89fa2
Removed obsolete XmlHelper.
AndyButland Mar 12, 2025
4511aa6
Fixed failing integration tests.
AndyButland Mar 12, 2025
2f24f78
Removed obsoletes in Umbraco.Cms.Api.Common
AndyButland Mar 13, 2025
8ffeadb
Removed obsoletes in Umbraco.Cms.Api.Delivery
AndyButland Mar 13, 2025
3a6261a
Removed obsoletes in Umbraco.Cms.Api.Management
AndyButland Mar 13, 2025
affa923
Removed obsoletes in Umbraco.Examine.Lucene
AndyButland Mar 13, 2025
b816e31
Removed obsoletes in Umbraco.Infrastructure
AndyButland Mar 13, 2025
0651ff2
Fix failing delivery API contract integration test.
AndyButland Mar 13, 2025
b8f5692
Made integration tests internal.
AndyButland Mar 13, 2025
2ec0221
Removed obsoletes from web projects.
AndyButland Mar 13, 2025
f10d3d0
Fix build.
AndyButland Mar 13, 2025
dd79da0
Removed Twitter OEmbed provider
AndyButland Mar 14, 2025
35504ce
Removed obsolete constructor on PublishedDataType.
AndyButland Mar 14, 2025
59a56e8
Removed obsolete constructors on PublishedCacheBase.
AndyButland Mar 14, 2025
7489c22
Merge branch 'v16/dev' into v16/task/remove-obsoletes
AndyButland Mar 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed obsolete HasSavedPropertyValues from IPropertyTypeUsageServic…
…e and IPropertyTypeUsageRepository.
AndyButland committed Mar 12, 2025
commit 2ab9b3bfdedf5e9a63435e814ebaa7c93c596cfb
Original file line number Diff line number Diff line change
@@ -2,8 +2,6 @@ namespace Umbraco.Cms.Core.Persistence.Repositories;

public interface IPropertyTypeUsageRepository
{
[Obsolete("Please use HasSavedPropertyValuesAsync. Scheduled for removable in Umbraco 15.")]
bool HasSavedPropertyValues(string propertyTypeAlias);
Task<bool> HasSavedPropertyValuesAsync(Guid contentTypeKey, string propertyAlias);
Task<bool> ContentTypeExistAsync(Guid contentTypeKey);
}
8 changes: 0 additions & 8 deletions src/Umbraco.Core/Services/IPropertyTypeUsageService.cs
Original file line number Diff line number Diff line change
@@ -4,14 +4,6 @@ namespace Umbraco.Cms.Core.Services;

public interface IPropertyTypeUsageService
{
/// <summary>
/// Checks if a property type has any saved property values associated with it.
/// </summary>
/// <param name="propertyTypeAlias">The alias of the property type to check.</param>
/// <returns>True if the property type has any property values, otherwise false.</returns>
[Obsolete("Please use HasSavedPropertyValuesAsync. Scheduled for removable in Umbraco 15.")]
bool HasSavedPropertyValues(string propertyTypeAlias);

/// <summary>
/// Checks if a property type has any saved property values associated with it.
/// </summary>
9 changes: 0 additions & 9 deletions src/Umbraco.Core/Services/PropertyTypeUsageService.cs
Original file line number Diff line number Diff line change
@@ -30,15 +30,6 @@ public PropertyTypeUsageService(
_scopeProvider = scopeProvider;
}

/// <inheritdoc/>
[Obsolete("Please use HasSavedPropertyValuesAsync. Scheduled for removable in Umbraco 15.")]
public bool HasSavedPropertyValues(string propertyTypeAlias)
{
using ICoreScope scope = _scopeProvider.CreateCoreScope(autoComplete: true);

return _propertyTypeUsageRepository.HasSavedPropertyValues(propertyTypeAlias);
}

/// <inheritdoc/>
public async Task<Attempt<bool, PropertyTypeOperationStatus>> HasSavedPropertyValuesAsync(Guid contentTypeKey, string propertyAlias)
{
Original file line number Diff line number Diff line change
@@ -22,29 +22,6 @@ public PropertyTypeUsageRepository(IScopeAccessor scopeAccessor)
_scopeAccessor = scopeAccessor;
}

[Obsolete("Please use HasSavedPropertyValuesAsync. Scheduled for removable in Umbraco 15.")]
public bool HasSavedPropertyValues(string propertyTypeAlias)
{
IUmbracoDatabase? database = _scopeAccessor.AmbientScope?.Database;

if (database is null)
{
throw new InvalidOperationException("A scope is required to query the database");
}

Sql<ISqlContext> selectQuery = database.SqlContext.Sql()
.SelectAll()
.From<PropertyTypeDto>("m")
.InnerJoin<PropertyDataDto>("p")
.On<PropertyDataDto, PropertyTypeDto>((left, right) => left.PropertyTypeId == right.Id, "p", "m")
.Where<PropertyTypeDto>(m => m.Alias == propertyTypeAlias, "m");

Sql<ISqlContext> hasValuesQuery = database.SqlContext.Sql()
.SelectAnyIfExists(selectQuery);

return database.ExecuteScalar<bool>(hasValuesQuery);
}

public Task<bool> HasSavedPropertyValuesAsync(Guid contentTypeKey, string propertyAlias)
{
IUmbracoDatabase? database = _scopeAccessor.AmbientScope?.Database;