Skip to content

set height to match workspace top bar #19384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nielslyngsoe
Copy link
Member

Align height of menu headlines with workspace top bar

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the styling of the section sidebar menu headlines to align with the workspace top bar.

  • Updates the h3 styles to use flexbox for vertical alignment
  • Sets a fixed height using a CSS variable and removes previous margin settings
Comments suppressed due to low confidence (2)

src/Umbraco.Web.UI.Client/src/packages/core/menu/section-sidebar-menu/section-sidebar-menu.element.ts:53

  • Ensure that the CSS variable '--umb-header-layout-height' is consistently defined across all environments to maintain proper alignment of the menu headlines with the workspace top bar.
height: var(--umb-header-layout-height);

src/Umbraco.Web.UI.Client/src/packages/core/menu/section-sidebar-menu/section-sidebar-menu.element.ts:51

  • [nitpick] The addition of 'display: flex' with 'align-items: center' improves vertical alignment; verify that there are no conflicts with parent container styles that might affect layout consistency.
display: flex;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant