fix context api test #19412
Open
fix context api test #19412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the context-consumer tests to align with the new behavior of the Context API, which no longer invokes callbacks with undefined by default.
- Swaps a type-only import for a concrete import of
UmbContextRequestEventImplementation - Converts several tests from callback-based
done()style toasync/awaitwithoneEvent - Ensures tests assert the absence of callback calls rather than expecting an initial
undefined
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/libs/context-api/consume/context-consumer.test.ts:277
- [nitpick] The
callbackCountvariable is initialized but never mutated in the new callback; consider removing it or using a spy to track invocations more directly.
let callbackCount = 0;
| localConsumer.hostConnected(); | ||
|
|
||
| await requestEvent; | ||
| await Promise.resolve(); |
There was a problem hiding this comment.
[nitpick] This extra await Promise.resolve() may be unnecessary now that you’re awaiting the event; you can remove it to simplify the test.
Suggested change
| await Promise.resolve(); |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the units tests as the context API does not call callback with undefined unless there was a instance send earlier.
the issue originates from this PR #19367