-
Notifications
You must be signed in to change notification settings - Fork 2.8k
E2E: QA Added acceptance tests for AllowEditInvariantFromNonDefault settings #21092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…anguages than default one
andr317c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a few comments
...sts.AcceptanceTest/tests/ContentSettingConfig/AllowEditInvariantFromNonDefaultIsTrue.spec.ts
Outdated
Show resolved
Hide resolved
andr317c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nhudinh0309
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some comments
| let textStringDataTypeId = ''; | ||
|
|
||
| test.beforeEach(async ({umbracoApi}) => { | ||
| await umbracoApi.documentType.ensureNameNotExists(documentTypeName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove lines 23–28, as they are already included in the create functions.
| await umbracoApi.document.ensureNameNotExists(contentName); | ||
| await umbracoApi.language.ensureIsoCodeNotExists('da'); | ||
| await umbracoApi.language.createDanishLanguage(); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this blank line
| * Expected: Properties NOT editable in non-default language (blocks shared) | ||
| */ | ||
|
|
||
| test('cannot save invariant property in invariant block when block list is invariant - non-default language', async ({umbracoApi, umbracoUi}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is duplicated with the test 'cannot edit invariant text property inside an invariant block in non-default language when AllowEditInvariantFromNonDefault is false' in AllowEditInvariantFromNonDefaultIsFalse.spec.ts
This PR adds the acceptance tests for #20868.
It should be merged once #20868 has been merged