Skip to content

Conversation

@nhudinh0309
Copy link
Contributor

@nhudinh0309 nhudinh0309 commented Dec 8, 2025

This PR adds the acceptance tests for #20868.
It should be merged once #20868 has been merged

Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few comments

Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

@nhudinh0309 nhudinh0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some comments

let textStringDataTypeId = '';

test.beforeEach(async ({umbracoApi}) => {
await umbracoApi.documentType.ensureNameNotExists(documentTypeName);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove lines 23–28, as they are already included in the create functions.

await umbracoApi.document.ensureNameNotExists(contentName);
await umbracoApi.language.ensureIsoCodeNotExists('da');
await umbracoApi.language.createDanishLanguage();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this blank line

* Expected: Properties NOT editable in non-default language (blocks shared)
*/

test('cannot save invariant property in invariant block when block list is invariant - non-default language', async ({umbracoApi, umbracoUi}) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is duplicated with the test 'cannot edit invariant text property inside an invariant block in non-default language when AllowEditInvariantFromNonDefault is false' in AllowEditInvariantFromNonDefaultIsFalse.spec.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants