E2E QA: Updated integration test that was missing directory setup #21167
+44
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes integration tests by adding necessary setup steps and updating test method signatures. The main issue was that LogViewer integration tests were failing because the log directory did not exist during test execution. The PR also updates a MemberType tree test to match an updated controller method signature.
- Created a new
LogViewerTestBaseclass that ensures the log directory exists before running tests - Updated five LogViewer integration test classes to inherit from the new base class
- Updated the
RootMemberTypeTreeControllerTeststo include the newfoldersOnlyparameter in the method signature
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Umbraco.Tests.Integration/ManagementApi/LogViewer/LogViewerTestBase.cs | New base class that creates the log directory in SetUp if it doesn't exist |
| tests/Umbraco.Tests.Integration/ManagementApi/LogViewer/ValidateLogFileSizeLogViewerControllerTests.cs | Changed base class from ManagementApiUserGroupTestBase to LogViewerTestBase and removed outdated comment |
| tests/Umbraco.Tests.Integration/ManagementApi/LogViewer/LogLevelCountLogViewerControllerTests.cs | Changed base class from ManagementApiUserGroupTestBase to LogViewerTestBase and removed outdated comment |
| tests/Umbraco.Tests.Integration/ManagementApi/LogViewer/AllSinkLevelLogViewerControllerTests.cs | Changed base class from ManagementApiUserGroupTestBase to LogViewerTestBase |
| tests/Umbraco.Tests.Integration/ManagementApi/LogViewer/AllMessageTemplateLogViewerControllerTests.cs | Changed base class from ManagementApiUserGroupTestBase to LogViewerTestBase and removed outdated comment |
| tests/Umbraco.Tests.Integration/ManagementApi/LogViewer/AllLogViewerControllerTests.cs | Changed base class from ManagementApiUserGroupTestBase to LogViewerTestBase and removed outdated comment |
| tests/Umbraco.Tests.Integration/ManagementApi/MemberType/Tree/RootMemberTypeTreeControllerTree.cs | Added the missing foldersOnly parameter (false) to match the updated controller method signature |
…files during cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.