Content: Fix name() and getName() to use active variant (closes #20759) #21171
+22
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntId provided When calling `name()` or `getName()` without a variantId argument, the methods now correctly return the name of the first active variant from the split view instead of always returning the first variant in the data array. The `name()` method now returns a reactive observable that updates when the active variant changes, using `mergeObservables` to combine the split view's active variant observable with the variants data. The `getName()` method now uses `splitView.getActiveVariants()[0]` to get the current active variant synchronously, with a fallback to the first variant if no active variant is set. This fixes an issue where block previews could not reactively observe the document name because the callback parameter was always empty. Closes #20759 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the name() and getName() methods in the content detail workspace to return the name of the currently active variant in the split view instead of always returning the first variant from the data array. This enables block previews to reactively observe document names when switching between language variants.
Key changes:
- Modified
getName()to retrieve the active variant from split view usinggetActiveVariants()[0]instead of always usingvariants[0] - Enhanced
name()to return a reactive observable that merges split view's active variant changes with variants data - Updated JSDoc documentation to clarify behavior when no variantId is provided
...mbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts
Show resolved
Hide resolved
Address PR review feedback by using UmbVariantId.Create() and compare() instead of direct property comparison. This ensures consistent behavior with the existing variant comparison pattern used throughout the codebase. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calling
name()orgetName()without a variantId argument, the methods now correctly return the name of the first active variant from the split view instead of always returning the first variant in the data array.Key changes:
name()returns a reactive observable that updates when the active variant changes, usingmergeObservablesto combine the split view's active variant observable with the variants datagetName()usessplitView.getActiveVariants()[0]to get the current active variant synchronously, with a fallback to the first variant if no active variant is setThis fixes an issue where block previews could not reactively observe the document name because the callback parameter was always empty when calling
context.name().Related Issues
Test plan
🤖 Generated with Claude Code