fix(frontend): Open variation editor modal via route registration#149
Merged
Merged
Conversation
Closes #144. The variation config editor modal was opened via modalManager.open(), so umb-modal mounted an UmbContextBoundary for UMB_ROUTE_CONTEXT instead of a real router-slot. Inside the modal, uai-mock-entity (PR #125) could no longer consume UMB_ROUTE_CONTEXT, its UmbModalRouteRegistrationController never fired, and the editor route path never resolved — so selecting a sub-type silently did nothing. Switch the variation builder to UmbModalRouteRegistrationController + history.pushState so the modal carries a router and the route context chain stays intact for the entity context picker (and any other route-registered editors hosted inside). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #144. Selecting a document type in the Entity Context picker on a test variation silently did nothing.
The variation config editor modal was opened via
modalManager.open(), so<umb-modal>mounted anUmbContextBoundaryoverUMB_ROUTE_CONTEXTinstead of a real<umb-router-slot>. Inside the modal,uai-mock-entity(added in #125) could no longer consumeUMB_ROUTE_CONTEXT, itsUmbModalRouteRegistrationControllernever fired, and#editorRoutePathnever resolved — so the sub-type click pushed nothing.This switches the variation builder to
UmbModalRouteRegistrationController+history.pushState, mirroringuai-mock-entity's own pattern. The modal now carries a router, publishesUMB_ROUTE_CONTEXTto its content, and the chain that #125 needs for nested block-grid editors stays intact.UaiTestVariationConfigEditorModalValuegets| undefinedadded for the same reasonUaiMockEntityEditorModalValuedoes —UmbModalRouteSetupReturn's typing only makesvalueoptional when the token's value type is... | undefined.Test plan
🤖 Generated with Claude Code