Fix GoogleMerchantCenterFeedService to make use of multiple value property extractors #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pleValuePropertyExtractor
umbracotrd
deleted the
features/13.1.3_fix-multiple-value-property-extractor
branch
umbracotrd
added a commit
that referenced
this pull request
Mar 18, 2025
…perty extractors (#29) * Add comments, rename variables and params * change some wordings * Rework GoogleMerchantCenterFeedService to actually make use of IMultipleValuePropertyExtractor * refactor how we're adding a new xml node * obsolete extension method and give a heads up about its namespace changing.
umbracotrd
added a commit
that referenced
this pull request
Mar 18, 2025
…perty extractors (#29) * Add comments, rename variables and params * change some wordings * Rework GoogleMerchantCenterFeedService to actually make use of IMultipleValuePropertyExtractor * refactor how we're adding a new xml node * obsolete extension method and give a heads up about its namespace changing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue in #27
IMultipleValuePropertyExtractor generates multiple nodes under the same name.
A nightly build
13.1.3--preview.2+3d4c292is available on Umbraco nightly build feed.The stable version will be pushed to nuget on March 17th, 2025