Skip to content

Ensure prepend and append in input is rounded#1396

Open
bjarnef wants to merge 3 commits into
umbraco:mainfrom
bjarnef:bug/input-prepend-append
Open

Ensure prepend and append in input is rounded#1396
bjarnef wants to merge 3 commits into
umbraco:mainfrom
bjarnef:bug/input-prepend-append

Conversation

@bjarnef
Copy link
Copy Markdown
Contributor

@bjarnef bjarnef commented May 25, 2026

Description

The new styling we more rounding cause issues with different component, e.g. with prepend/append:
https://uui.umbraco.com/?path=/story/uui-input--prepend-and-append

Also not sure why the input need to have a different top/bottom padding, which in general don't align label in center of input.

Before

image

After

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copilot AI review requested due to automatic review settings May 25, 2026 05:35
@github-actions
Copy link
Copy Markdown

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adjusts the input component’s layout styling to prevent visual bleed and simplify padding.

Changes:

  • Adds overflow: hidden to the input container styles.
  • Replaces a 4-value --uui-input-padding with a 2-value shorthand.

var(--uui-input-border-color, var(--uui-color-border));
border-radius: var(--uui-input-border-radius, var(--uui-border-radius));
min-width: 0;
overflow: hidden;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine. Focus outline is still shown.

Comment thread src/components/input/input.element.ts Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants