Ensure prepend and append in input is rounded#1396
Conversation
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts the input component’s layout styling to prevent visual bleed and simplify padding.
Changes:
- Adds
overflow: hiddento the input container styles. - Replaces a 4-value
--uui-input-paddingwith a 2-value shorthand.
| var(--uui-input-border-color, var(--uui-color-border)); | ||
| border-radius: var(--uui-input-border-radius, var(--uui-border-radius)); | ||
| min-width: 0; | ||
| overflow: hidden; |
There was a problem hiding this comment.
Seems to work fine. Focus outline is still shown.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|



Description
The new styling we more rounding cause issues with different component, e.g. with prepend/append:
https://uui.umbraco.com/?path=/story/uui-input--prepend-and-append
Also not sure why the input need to have a different top/bottom padding, which in general don't align label in center of input.
Before
After
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist