Upgrade to f2 instances #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades FPGA instance configurations from the legacy fpga type to the newer fpga2 type for specific DRAGEN tools (versions 4.4.4 and 4.4.6), resolving recent pipeline failures caused by using the incorrect instance type.
- Changed instance type from
fpgatofpga2across 5 CWL tool definitions - Standardized resource allocations to 24 cores and 256000 MB RAM across all updated tools
- Targeted specific tool versions (4.4.4 and 4.4.6) that were experiencing failures
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tools/get-dragen-default-configuration-json/4.4.6/get-dragen-default-configuration-json__4.4.6.cwl |
Updated to fpga2 instance type with increased resources (2→24 cores, 4000→256000 MB RAM) |
tools/get-dragen-default-configuration-json/4.4.4/get-dragen-default-configuration-json__4.4.4.cwl |
Updated to fpga2 instance type with increased resources (2→24 cores, 4000→256000 MB RAM) |
tools/dragen-wgts-rna-variant-calling-step/4.4.4/dragen-wgts-rna-variant-calling-step__4.4.4.cwl |
Updated to fpga2 instance type with adjusted resources (16→24 cores, 240000→256000 MB RAM) |
tools/dragen-wgts-dna-variant-calling-step/4.4.6/dragen-wgts-dna-variant-calling-step__4.4.6.cwl |
Updated to fpga2 instance type with adjusted resources (16→24 cores, 240000→256000 MB RAM) |
tools/dragen-wgts-dna-variant-calling-step/4.4.4/dragen-wgts-dna-variant-calling-step__4.4.4.cwl |
Updated to fpga2 instance type with adjusted resources (16→24 cores, 240000→256000 MB RAM) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ohofmann
approved these changes
Jan 4, 2026
Member
ohofmann
left a comment
ohofmann
left a comment
There was a problem hiding this comment.
LGTM — not like we have a choice anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misunderstanding, thought the instance for fpga types were associated with the docker image but there is actually an 'fpga2' type now.
Explains the falling over of the recent runs.