Skip to content

feat: conditional expression supports comma operator#593

Open
kayoch1n wants to merge 2 commits into
umijs:masterfrom
kayoch1n:master
Open

feat: conditional expression supports comma operator#593
kayoch1n wants to merge 2 commits into
umijs:masterfrom
kayoch1n:master

Conversation

@kayoch1n
Copy link
Copy Markdown

@kayoch1n kayoch1n commented Aug 30, 2021

import { NewPage, OldPage } from "components"; // 使用按需加载的两个控件

let condition = 1, temp = '';
let Tag = condition? (temp = 'New', NewPage) : (temp = 'Old', OldPage); // 无法渲染

在条件表达式的 consequent 或者 alternate 部分使用了 comma opereator 的情况下,原来的代码仍然会导致渲染失败,类似这个issue

先前的这个 PR 对声明语句做了修复了,但是没有cover到其他表达式

@kayoch1n
Copy link
Copy Markdown
Author

kayoch1n commented Sep 2, 2021

@sorrycc 打搅一下,有时间review一下不?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant