fix: ui error when no auth providers configured#1640
Open
Jaskon wants to merge 1 commit intoumputun:masterfrom
Open
fix: ui error when no auth providers configured#1640Jaskon wants to merge 1 commit intoumputun:masterfrom
Jaskon wants to merge 1 commit intoumputun:masterfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1640 +/- ##
==========================================
+ Coverage 61.55% 61.57% +0.02%
==========================================
Files 133 133
Lines 3004 3006 +2
Branches 752 761 +9
==========================================
+ Hits 1849 1851 +2
- Misses 1038 1151 +113
+ Partials 117 4 -113
☔ View full report in Codecov by Sentry. |
paskal
approved these changes
Jun 29, 2023
umputun
force-pushed
the
1456-ui-error-no-auth-providers
branch
from
e804e42 to
ee2c352
Compare
paskal
force-pushed
the
1456-ui-error-no-auth-providers
branch
from
ee2c352 to
74fd5a8
Compare
paskal
reviewed
Sep 16, 2023
| id: 'auth.signout', | ||
| defaultMessage: 'Sign Out', | ||
| }, | ||
| noProviders: { |
Collaborator
There was a problem hiding this comment.
I think you need to add a translation string and regenerate translations in case you're adding new text like that.
Collaborator
|
@Jaskon can you please finalise that PR so that we could merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue
Please correct me if i'm wrong: view variable (telegram/token/email) is only exist after some action in the dropdown menu. So its not necessary to check here that view is equal to something and checks provided in my PR is enough