Fix email encoding, image cleanup CPU spin, and demo template paths#2000
Merged
Fix email encoding, image cleanup CPU spin, and demo template paths#2000
Conversation
URL-encode e.From in mailto query parameters so that + characters are preserved instead of being decoded as spaces. Fixes #1946
When EditDuration is zero or negative, cleanupTTL becomes zero, causing time.After(0) to fire immediately in a tight loop. Block on ctx.Done() instead when edit duration is disabled. Fixes #1991
Use REMARK_URL template variable for widget links so demo page works with non-root path prefixes. Fixes #1996
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2000 +/- ##
==========================================
- Coverage 64.88% 62.19% -2.70%
==========================================
Files 140 132 -8
Lines 3258 3026 -232
Branches 815 721 -94
==========================================
- Hits 2114 1882 -232
- Misses 1030 1140 +110
+ Partials 114 4 -110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes bundled together:
+sign #1946 — URL-encodee.Fromin mailto query parameters so+characters inNOTIFY_EMAIL_FROMare preserved instead of being decoded as spacesCleanupgoroutine againstEditDuration <= 0to prevent 100% CPU fromtime.After(0)firing in a tight loop/web/paths indemo.ejswith theREMARK_URLtemplate variable so the demo page works with non-root path prefixesFixes #1946, fixes #1991, fixes #1996