Clear user placeholder content when comments iframe loads#2002
Merged
Clear user placeholder content when comments iframe loads#2002
Conversation
Remove non-iframe child nodes from the root element once the iframe signals it has initialised, allowing users to add loading placeholders that get cleaned up automatically. Fixes #1990
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2002 +/- ##
==========================================
- Coverage 64.88% 62.13% -2.76%
==========================================
Files 140 132 -8
Lines 3258 3029 -229
Branches 815 721 -94
==========================================
- Hits 2114 1882 -232
- Misses 1030 1143 +113
+ Partials 114 4 -110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow users to add placeholder content (e.g. a loading spinner or "Loading comments..." text) inside the
remark42root div. When the iframe signals it has initialised, all non-iframe child nodes are removed from the root element.This lets users show something meaningful while the comment widget loads without any changes to the embed script configuration.
Fixes #1990