-
Notifications
You must be signed in to change notification settings - Fork 13
make rasters work with products that cross antimeridian #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
remark : the footprint in dataset.attrs will be defined from longitudes in [-180;180], so the Polygon is not good. The footprint comes from Note that if we apply At the moment we decide to keep the |
agrouaze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No remarks on the code itself.
But on the PR, can you:
- describe the scope of the PR (is it for RS2, RMC and S1?, what was the status before this PR? why ECMWF raster is impacted?)
- can you add a unit test with a real product crossing the anti meridian or a
mockproduct? - can you confirm
sphinxcompiles successfully - can you confirm
pytestare successful
|
files concerned are files that cross the antimeridian (RS2/RCM/S1). Before the PR, an error was generated. |
|
https://github.com/umr-lops/mapraster will make map_raster out of |
|
I agree that adding a (or several) unit test for the specific case of anti-meridian crossing is a good idea ! |
|
@agrouaze doc OK |
vincelhx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review
|
just waiting for the conda version of 'mapraster' |
|
@agrouaze @oceanscoper mapraster is now on conda-forge. could you validate this PR? |
vincelhx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
files concerned are files that cross the antimeridian (RS2/RCM/S1). Before the PR, an error was generated.
rasters are concerned because there is an operation of mapping the raster on the grid, it requires continuity.