Skip to content

Conversation

@vincelhx
Copy link
Collaborator

@vincelhx vincelhx commented Dec 15, 2025

files concerned are files that cross the antimeridian (RS2/RCM/S1). Before the PR, an error was generated.
rasters are concerned because there is an operation of mapping the raster on the grid, it requires continuity.

@vincelhx vincelhx marked this pull request as draft December 15, 2025 13:48
@vincelhx vincelhx marked this pull request as ready for review December 16, 2025 10:44
@vincelhx
Copy link
Collaborator Author

remark : the footprint in dataset.attrs will be defined from longitudes in [-180;180], so the Polygon is not good. The footprint comes from BaseMeta.footprint that comes from BaseMeta.geoloc.

Note that if we apply BaseDataset.recompute_attrs() for the cases that cross antimeridian, the footprint get defined in [0,360], as in BaseDataset.footprint and the polygon is correct.

At the moment we decide to keep the .dataset['footprint'] polygon to have an homogeneous code.

Copy link
Member

@agrouaze agrouaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No remarks on the code itself.
But on the PR, can you:

  • describe the scope of the PR (is it for RS2, RMC and S1?, what was the status before this PR? why ECMWF raster is impacted?)
  • can you add a unit test with a real product crossing the anti meridian or a mock product?
  • can you confirm sphinx compiles successfully
  • can you confirm pytest are successful

@agrouaze agrouaze added the enhancement New feature or request label Dec 16, 2025
@vincelhx
Copy link
Collaborator Author

files concerned are files that cross the antimeridian (RS2/RCM/S1). Before the PR, an error was generated.
rasters are concerned because there is an operation of mapping the raster on the grid, it requires continuity.

@vincelhx
Copy link
Collaborator Author

https://github.com/umr-lops/mapraster will make map_raster out of xsar

@oceanscoper
Copy link
Collaborator

I agree that adding a (or several) unit test for the specific case of anti-meridian crossing is a good idea !

@vincelhx
Copy link
Collaborator Author

@agrouaze doc OK

@vincelhx vincelhx requested a review from agrouaze December 30, 2025 13:26
Copy link
Collaborator Author

@vincelhx vincelhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

@vincelhx
Copy link
Collaborator Author

vincelhx commented Jan 5, 2026

just waiting for the conda version of 'mapraster'

@vincelhx
Copy link
Collaborator Author

vincelhx commented Jan 6, 2026

@agrouaze @oceanscoper mapraster is now on conda-forge. could you validate this PR?

@vincelhx vincelhx requested a review from agrouaze January 7, 2026 10:27
Copy link
Collaborator Author

@vincelhx vincelhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@vincelhx vincelhx merged commit f3f3248 into umr-lops:develop Jan 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants