fix ytdl on linux#168
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the project’s YouTube/yt-dlp integration by centralizing yt-dlp options, adjusting download format selection, and updating related dependencies.
Changes:
- Adds a
jsRuntimesyt-dlp option (likely to improve JS extraction reliability) via shared options. - Switches the MusicPlayer download path to use
YouTube.getYtDlpOptions(...)and updates the selected yt-dlp format. - Updates dependencies: bumps
youtube-dl-execand replacesytdl-corewith@distube/ytdl-core.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/YouTube.js | Adds jsRuntimes to shared yt-dlp options. |
| src/MusicPlayer.js | Reuses shared yt-dlp options and adjusts yt-dlp format selection. |
| package.json | Updates downloader/core media dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| retries: 3, | ||
| fragmentRetries: 3, | ||
| // User-Agent header ekle | ||
| jsRuntimes: `node:${process.execPath}`, |
Comment on lines
+614
to
+616
| await youtubedl(downloadUrl, YouTube.getYtDlpOptions({ | ||
| output: filepath, | ||
| format: 'bestaudio', | ||
| noCheckCertificates: true, | ||
| noWarnings: true, | ||
| format: 'bestaudio/best', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for my part, the bot wasn't working on my Debian server (because of ytdl)
these few commits fix the issues
up to you whether or not to merge them