fix: pass prompt as CLI arg instead of stdin - #5
Open
dep wants to merge 1 commit into
Open
Conversation
The baseline arm intermittently failed with "Input must be provided either through stdin or as a prompt argument when using --print". Passing the prompt via stdin raced against the CLI's stdin-availability check. Switching to a positional prompt arg avoids the race, but exposed a second bug: the variadic --disallowed-tools flag greedily consumed the entire prompt as additional tool names since nothing terminated the option list. Fixed by passing all disallowed tools in one call and adding -- before the prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--disallowed-tools <tools...>flag greedily consumed the entire trailing prompt as additional tool names since nothing terminated the option list.--before the prompt to terminate option parsing.Test plan
bunx tsc --noEmit -p .passesbun start -- --repo <repo> --task "..."— both baseline and unblocked arms completed successfully (exit=0) with no parsing errors