Add considerations, advice, requirements #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamineskola
force-pushed
the
preapp-report-advice
branch
16 times, most recently
from
3b6ae9b to
98d0a49
Compare
|
Probably one for design as I've seen it matches figma but seems weird that the Planning considerations and advice table has 'complies' but the description of the acceptability says 'supported'? |
|
Good point. I think this is just in the database as 'complies' but it sounds like we might need to map it to 'supported', etc, at least for displaying it in the report page. |
benjamineskola
force-pushed
the
preapp-report-advice
branch
10 times, most recently
from
f768eba to
188c7d8
Compare
benjamineskola
force-pushed
the
preapp-report-advice
branch
4 times, most recently
from
4de1391 to
2897a98
Compare
benjamineskola
force-pushed
the
preapp-report-advice
branch
from
2897a98 to
799d3c9
Compare
EGiataganas
approved these changes
Apr 11, 2025
benbaumann95
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adding sections to preapp report: guidance, considerations etc.
Story Link
https://trello.com/c/Ar2TQi8u/549-pre-app-preview-and-submit-final-report-advice
Screenshots
Considerations
Requirements