Repository navigation
Conversation
Owner
|
Hi @NicodeSS, thanks for the PR. I will take a look at it later today. I've developed a split button solution in a branch, but I might not have pushed it to the repo yet - sorry about that. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Expose the existing media-session switcher directly in the media flyout. The original player button remains when only one eligible session is available.
Why
The current switcher is only discoverable through a right-click on the player button in the normal layout. Compact layout has no equivalent entry point. A visible selector makes switching available in both layouts without changing the underlying session-selection policy.
Changes
PinnedSessionIdsetting.This PR changes the selection UI only. It does not change how the current media session is chosen or stored.
Maintainer note
You mentioned developing a SplitButton implementation in your own branch. I could not locate that implementation in the public branches or PRs I checked, so this is a working UI proposal for now. I am happy to adapt this PR to your version, or replace this SplitButton with it once it is available.
Testing
dotnet build FluentFlyoutWPF/FluentFlyout.csproj -c Debug --no-restore -v quiet— passed (0 errors; 54 warnings also present on the unmodified base).dotnet format FluentFlyout.sln --verify-no-changes --no-restore --verbosity quiet— passed.