Repository navigation
Add headphone controls support for media flyout - #1194
FaroJoaoFaro wants to merge 2 commits into
Conversation
Show the media flyout when media or volume is controlled from Bluetooth headphones or other external devices, not only keyboard media keys. - Accept media/volume app commands sent by OEM devices in the shell hook - Detect volume changes made without keyboard or mouse input - Detect play/pause toggles made without keyboard or mouse input - Add "Headphone Controls" setting (off by default)
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read and agree to the FluentFlyout CLA |
|
recheck |
Remove newlines at end of files
unchihugo
left a comment
There was a problem hiding this comment.
Hi @FaroJoaoFaro, thanks for the PR, looks good. Is there a reason you prefer this to be a toggleable feature that's off by default instead of being always on?
To be honest I would always use it on, and I, personally, wouldn't even need to have this option, but I thought this could be a desired option so I added it. Tell me if you need me to modify it and I'll change it |
|
I forgot to add but I tested this on a pair of Sony wh-1000xm5 |
Sounds good. Have you tested this against edge-case scenarios e.g. frequently disconnecting and reconnecting the Bluetooth device, switching Bluetooth devices, and after device sleep/hibernation? |
|
I didn't but I can try to do it tomorrow! As for the settings do you want me to change anything? |
|
Tested on Sony WH-1000XM5 (Windows 11). Results with Headphone Controls enabled:
Not tested: multipoint (headset connected to a phone at the same time) and hibernation. One unrelated finding: restarting the Windows Audio service crashes the app with |
unchihugo
left a comment
There was a problem hiding this comment.
Hi @FaroJoaoFaro, I just tested out the branch on my own Bluetooth devices and noticed that the volume flyout (native or FluentFlyout's) doesn't display when volume has been changed, if the device had already been connected before starting, and the volume flyout setting is turned on. I'm not getting anything in the logs, so not sure what's going on. Are you able to check this out?
|
I will test it and attempt to fix! |
Show the media flyout when media or volume is controlled from Bluetooth headphones or other external devices, not only keyboard media keys.
Summary
Show the media flyout when media or volume is controlled from Bluetooth headphones or other external devices, not only from keyboard media keys. This is behind a new "Headphone Controls" setting, off by default.
Motivation
I use Bluetooth headphones and wanted the flyout to show when I change the volume or play/pause from the headphones. Right now it only shows for keyboard media keys, so using the headphone controls gives no on-screen feedback. More users wanted this change
Closes #18, and should also close duplicates: #286 and #354
Type of Change
What Changed
Additional Information
Checklist