Skip to content

[Feature] Improved Visualizer - #497

Merged
unchihugo merged 2 commits into
unchihugo:masterfrom
Hikaru11747:feature/ImprovedVisualizer
Mar 21, 2026
Merged

unchihugo merged 2 commits into
unchihugo:masterfrom
Hikaru11747:feature/ImprovedVisualizer

Conversation

@Hikaru11747

Copy link
Copy Markdown
Contributor

Improved how visualizer looks and feels, now using SDFs to draw the rounded corners (follows the win 11 rounded pill design), and optimized for better performance.

@unchihugo unchihugo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hikaru11747, good performance improvements! The rounding change is a concern though — bars are now fully pill-shaped rather than the fixed radius users are already used to. Can you separate the rounding change so we can merge this performance refactor? Thanks!

@Hikaru11747

Copy link
Copy Markdown
Contributor Author

I do understand the round pill concern, will it be better if I give an option customise it by the user? A drop down to select fully squared (no radius), fixed radius and pill as styles?

@unchihugo

Copy link
Copy Markdown
Owner

I do understand the round pill concern, will it be better if I give an option customise it by the user? A drop down to select fully squared (no radius), fixed radius and pill as styles?

That's true, and I had thought about this as well. That said, I've weighed the pros and cons extensively, and I think we should keep it as the original behavior for now: we're already presenting the user with quite the amount of customization options, and a new option could contribute to more fatigue or indecisiveness (I've already noticed that most users keep settings at default other than enabling/disabling features). I'd prefer we keep the current behavior, and see whether users would like a feature like this in the future. Feel free to open an issue about this!

@Hikaru11747
Hikaru11747 force-pushed the feature/ImprovedVisualizer branch from 4e7f721 to 7673b63 Compare March 21, 2026 19:49
@Hikaru11747
Hikaru11747 requested a review from unchihugo March 21, 2026 19:49

@unchihugo unchihugo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @Hikaru11747! Looks good now. I've tested the performance difference myself, and we're looking at about a ~5.5ms processing time @ 30fps, 10 bars (~12ms before your refactor) on my computer, so about 2.2x faster! Thanks for the improvement :)

@unchihugo
unchihugo merged commit 339a296 into unchihugo:master Mar 21, 2026
1 check passed
@Hikaru11747
Hikaru11747 deleted the feature/ImprovedVisualizer branch March 31, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants