Skip to content

Fix dict type proxy_config handle issue #1057 #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix dict type proxy_config handle issue #1057 #1058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions crawl4ai/async_configs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,8 +439,11 @@ def __init__(
self.channel = ""
self.chrome_channel = ""
self.proxy = proxy
self.proxy_config = proxy_config

if isinstance(proxy_config, dict):
self.proxy_config = ProxyConfig.from_dict(proxy_config)
else:
self.proxy_config = proxy_config

self.viewport_width = viewport_width
self.viewport_height = viewport_height
Expand Down Expand Up @@ -976,7 +979,12 @@ def __init__(
self.prettiify = prettiify
self.parser_type = parser_type
self.scraping_strategy = scraping_strategy or WebScrapingStrategy()
self.proxy_config = proxy_config

if isinstance(proxy_config, dict):
self.proxy_config = ProxyConfig.from_dict(proxy_config)
else:
self.proxy_config = proxy_config

self.proxy_rotation_strategy = proxy_rotation_strategy

# Browser Location and Identity Parameters
Expand Down