Fix: request /crawl
with stream: true
issue #1066
#1074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1066
This PR fixes the error that happens when you send a request to /crawl with
stream: true
in thecrawler_config
.What’s the fix?
If a request has
stream: true
, it now automatically redirects (307) to the/crawl/stream
endpoint.No more
async_generator
errorsList of files changed and why
deploy/docker/server.py
deploy/docker/static/playground/index.html
/crawl
:stream is False,/crawl/stream
: stream is True )tests/docker/test_server_requests.py
How Has This Been Tested?
Tested with curl(like the issue example)
eg.
Got a 307 redirect to /crawl/stream, and the streaming worked!
Checklist: