Skip to content

fix: address temperature typo in LLMConfig class #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mvdmakesthings
Copy link

@mvdmakesthings mvdmakesthings commented May 7, 2025

Summary

Simply fixing a typo ("temprature" vs "temperature") found in the LLMConfig class. These changes seek to align the spelling with what is generally expected in LiteLLM's documentation.

This would be a breaking API change because existing implementations would need to adopt the new spelling.

List of files changed and why

  • crawl4ai/async_configs.py - To update the LLMConfig "temperature" constructor initializer and instance member spelling.
  • crawl4ai/extraction_strategy.py - Updating "temperature" spelling in the LLMExtractionStrategy docstring.
  • deploy/docker/c4ai-code-context.md - Updating the docker code-context file with the correct spelling. I was unsure if this was necessary as it seems this file is generated but was unable to find where/how it was generated. I am happy to remove this code change, just wanted to be thorough.

How Has This Been Tested?

  • Locally ran test_llm_filter.py
Screenshot 2025-05-07 at 4 45 47 PM
  • Locally ran test_serialization.py
Screenshot 2025-05-07 at 4 50 08 PM

I was unable to get the other tests to run due to environmental issues, unrelated to the above code changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added/updated unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@mvdmakesthings mvdmakesthings marked this pull request as ready for review May 7, 2025 20:55
@mvdmakesthings mvdmakesthings changed the title fix: address temperature typo in LLMConfig class params fix: address temperature typo in LLMConfig class May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant