fix(deep-crawl): ContextVar crash in streaming deep crawl (#1917)#1922
Open
fix(deep-crawl): ContextVar crash in streaming deep crawl (#1917)#1922
Conversation
#1917) ContextVar.reset(token) requires the same Context that created the token. When Starlette's StreamingResponse consumes the async generator in a different Task, the Context changes and reset() raises ValueError. Replaced with set(False) which works across context boundaries. Safe because deep_crawl_active is never nested — the guard on line 21 prevents re-entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeepCrawlDecoratorusedContextVar.reset(token)in the async generator'sfinallyblock. When Starlette'sStreamingResponseconsumes the generator in a different asyncio Task (differentContext),reset()raisesValueError: was created in a different Context.reset(token)withset(False)on both the streaming and batch paths. Safe becausedeep_crawl_activeis never nested — the guard on line 21 prevents re-entry.Test plan
/crawl/streamendpoint: 3/3 requests crash before fix, 0/3 aftertests/deep_crawling/test_deep_crawl_contextvar.py)