Skip to content

[UNDERTOW-2356] Use state updater to sync up state transitions#1704

Closed
baranowb wants to merge 30 commits intoundertow-io:mainfrom
baranowb:UNDERTOW-2356
Closed

[UNDERTOW-2356] Use state updater to sync up state transitions#1704
baranowb wants to merge 30 commits intoundertow-io:mainfrom
baranowb:UNDERTOW-2356

Conversation

@baranowb
Copy link
Copy Markdown
Contributor

@baranowb baranowb added enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review labels Nov 14, 2024
@baranowb baranowb requested review from fl4via and ropalka November 14, 2024 09:15
Copy link
Copy Markdown
Contributor

@jasondlee jasondlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@baranowb baranowb changed the title [UNDERTOW-2356] Use state updated to sync up state transitions [UNDERTOW-2356] Use state updater to sync up state transitions Dec 5, 2024
baranowb and others added 21 commits December 5, 2024 11:12
…foreServerStarts and @AfterServerStops for simpler before and after methods

Signed-off-by: Flavia Rainone <frainone@redhat.com>
…ut to verify if the timeout is working, and increase the interval of tolerance for the time spent

This may work better on slower machines when running this test.

Signed-off-by: Flavia Rainone <frainone@redhat.com>
…ndows"

The tests were disabled in CI by mistake and this prevented us seeing that those tests still need to be fixed so they can work in Windows

This reverts commit abc70e2.
…ting view; enable clickable name and size column headers for custom sorting
@baranowb
Copy link
Copy Markdown
Contributor Author

baranowb commented Dec 5, 2024

ok,. this is BS. git rebase is broken. Im going to redo PR

@baranowb baranowb closed this Dec 5, 2024
@baranowb
Copy link
Copy Markdown
Contributor Author

baranowb commented Dec 5, 2024

Check #1711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhances existing behaviour or code under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants