Repository navigation
Conversation
baranowb
added
enhancement
baranowb
force-pushed
the
UNDERTOW-2593
branch
from
August 27, 2025 13:44
5d47215 to
77ad1d4
Compare
baranowb
force-pushed
the
UNDERTOW-2593
branch
from
October 29, 2025 11:07
77ad1d4 to
aadae47
Compare
jasondlee
reviewed
Nov 17, 2025
|
|
||
| @LogMessage(level = ERROR) | ||
| @Message(id = 5109, value = "Ignoring specified SameSite mode [%s] for cookie [%s].") | ||
| void ignoreSameSiteCookieMode(@Cause Throwable e, String mode, String name); |
Contributor
There was a problem hiding this comment.
The original message was at WARN, but this is at ERROR. Is that intentional/correct?
jasondlee
reviewed
Nov 17, 2025
|
|
||
| @LogMessage(level = ERROR) | ||
| @Message(id = 15025, value = "Ignoring specified SameSite mode [%s] for cookie [%s].") | ||
| void ignoreSameSiteCookieMode(@Cause Throwable e, String mode, String name); |
Contributor
There was a problem hiding this comment.
Same WARN -> ERROR question.
fl4via
requested changes
Mar 3, 2026
fl4via
left a comment
fl4via
left a comment
Member
There was a problem hiding this comment.
@baranowb please view the points raised by @jasondlee
fl4via
added
waiting PR update
Contributor
Author
|
changed to WARN - it was sort of protocol error, but maybe its better to treat is as runeimt error. |
baranowb
removed
waiting PR update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/UNDERTOW-2593