Skip to content

[UNDERTOW-2395] ensure proper encoding in RelativePathAttribute#1848

Open
michpetrov wants to merge 1 commit intoundertow-io:mainfrom
michpetrov:undertow-2395
Open

[UNDERTOW-2395] ensure proper encoding in RelativePathAttribute#1848
michpetrov wants to merge 1 commit intoundertow-io:mainfrom
michpetrov:undertow-2395

Conversation

@michpetrov
Copy link
Copy Markdown

@michpetrov michpetrov commented Nov 28, 2025

Issue: UNDERTOW-2395

Presumably this would also be useful to the other attributes that handle relative path but given the lack of clarity concerning the intended result and because this is the only attribute that is concerned with encoding this is a fix specifically for the reported issue.

@baranowb baranowb added bug fix Contains bug fix(es) under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review labels Dec 2, 2025
@fl4via fl4via added next release This PR will be merged before next release or has already been merged (for payload double check) and removed under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review labels Mar 3, 2026
@fl4via fl4via added waiting CI check Ready to be merged but waiting for CI check failed CI Introduced new regession(s) during CI check waiting PR update Awaiting PR update(s) from contributor before merging and removed waiting CI check Ready to be merged but waiting for CI check next release This PR will be merged before next release or has already been merged (for payload double check) labels Mar 3, 2026
@fl4via
Copy link
Copy Markdown
Member

fl4via commented Mar 3, 2026

@michpetrov the PR is not compiling after I rebased the branch. Can you please update the PR? If you need a hand, please let me know.

@michpetrov
Copy link
Copy Markdown
Author

michpetrov commented Mar 20, 2026

@fl4via fixed, not sure what happened there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasondlee jasondlee jasondlee approved these changes

@fl4via fl4via fl4via approved these changes

@ropalka ropalka Awaiting requested review from ropalka

@jamezp jamezp Awaiting requested review from jamezp

@baranowb baranowb Awaiting requested review from baranowb

Assignees

No one assigned

Labels

bug fix Contains bug fix(es) failed CI Introduced new regession(s) during CI check waiting PR update Awaiting PR update(s) from contributor before merging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michpetrov @fl4via @jasondlee @baranowb