[UNDERTOW-2719] fix: replace printStackTrace() with proper logging#1929
Open
Senrian wants to merge 1 commit intoundertow-io:mainfrom
Open
[UNDERTOW-2719] fix: replace printStackTrace() with proper logging#1929Senrian wants to merge 1 commit intoundertow-io:mainfrom
Senrian wants to merge 1 commit intoundertow-io:mainfrom
Conversation
- Version.java: use ROOT_LOGGER.error for version loading failures - AsyncReceiverImpl.java: remove redundant printStackTrace (already logs via REQUEST_IO_LOGGER) - MCMPHandler.java: use PROXY_LOGGER.debug for ping response errors - WebSocketChannel.java: use WEB_SOCKET_LOGGER.debug for close message errors - DefaultByteBufferPool.java: use ROOT_LOGGER.debug for finalize cleanup warnings
fl4via
changed the title
fl4via
requested changes
Mar 4, 2026
Member
fl4via
left a comment
fl4via
left a comment
There was a problem hiding this comment.
Please, add the previx [UNDERTOW-2719] to your commit message
fl4via
added
the
waiting PR update
baranowb
approved these changes
Mar 24, 2026
Contributor
|
Needs update of commit message but other than that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace printStackTrace() calls with proper logging using UndertowLogger in 5 files.
Jira: https://issues.redhat.com/browse/UNDERTOW-2719