Diffusion bits #311
Open
Diffusion bits #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solver updates -Add a diffusion solver -symbolic ddt -Eulerian ddt CM updates -Anisotropic diffusion CM -Flux CM, allowing flux terms to be passed directly into the solver
Functions now appear correctly in the view() function
Folded into solvers.py
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new diffusion functionality, including a diffusion solver, a generic flux constitutive model, and an anisotropic diffusion constitutive model, along with Eulerian and symbolic strategies for history management.
- Adds SNES_Diffusion class and integrates Eulerian and Symbolic history methods in solvers.
- Updates module initializers to expose the new diffusion solver.
- Extends maths functions with an L2_norm function and introduces new constitutive models for anisotropic diffusion and generic flux.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/underworld3/systems/solvers.py | Adds SNES_Diffusion with new history management and solver setup |
| src/underworld3/systems/init.py | Exposes the new diffusion-only solver and relevant DDt imports |
| src/underworld3/maths/functions.py | Introduces a new L2_norm function for norm computations |
| src/underworld3/maths/init.py | Imports the new L2_norm function |
| src/underworld3/constitutive_models.py | Adds AnisotropicDiffusionModel and GenericFluxModel to support diffusion properties |
Comments suppressed due to low confidence (1)
src/underworld3/systems/init.py:37
- The module imports 'SemiLagragian_DDt' but elsewhere the union types and similar imports use the name 'SemiLagrangian_DDt'. Consider aligning the naming for consistency.
from .ddt import SemiLagragian_DDt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in: