Prevent snake_case identifiers from being detected as LaTeX math#291
Merged
elasticsounds merged 1 commit intomainfrom Apr 17, 2026
Merged
Prevent snake_case identifiers from being detected as LaTeX math#291elasticsounds merged 1 commit intomainfrom
elasticsounds merged 1 commit intomainfrom
Conversation
Tighten the bare subscript/superscript patterns in UNDELIMITED_LATEX_RE and LATEX_EXPR_RE with lookaround assertions so identifiers like `variable_name` are no longer matched, while expressions like `X_i` and `X^2` still convert correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UNDELIMITED_LATEX_REandLATEX_EXPR_REinpackages/pipeline/src/package-web.tswith lookaround assertions so bare subscript/superscript atoms no longer match insidesnake_caseidentifiers likevariable_name, whileX_i/X^2continue to convert.packages/pipeline/src/__tests__/package-web.test.ts: one for pure prose containingvariable_name/snake_case, and one for mixed prose wherevariable_namemust be preserved alongside a realX_imath fragment.Test plan
pnpm --filter @adt/pipeline testpasses, including the two newconvertLatexToMathml (HTML)cases.